Closed arturovt closed 3 years ago
Merging #98 (ff92b42) into master (50042e8) will increase coverage by
2.47%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 84.31% 86.78% +2.47%
==========================================
Files 31 50 +19
Lines 459 545 +86
Branches 65 65
==========================================
+ Hits 387 473 +86
+ Misses 72 71 -1
- Partials 0 1 +1
Impacted Files | Coverage Δ | |
---|---|---|
...ects/elements-demo/src/app/shared/shared.module.ts | 100.00% <0.00%> (ø) |
|
...ments-demo/src/app/features/docs/docs.component.ts | 100.00% <0.00%> (ø) |
|
...ments-demo/src/app/shared/error/error.component.ts | 100.00% <0.00%> (ø) |
|
...ents/src/lib/lazy-elements/lazy-elements.module.ts | 100.00% <0.00%> (ø) |
|
...ents/src/lib/lazy-elements/lazy-elements.tokens.ts | 100.00% <0.00%> (ø) |
|
...ts-demo/src/app/features/docs/api/api.component.ts | 100.00% <0.00%> (ø) |
|
...ts-demo/src/app/features/docs/faq/faq.component.ts | 100.00% <0.00%> (ø) |
|
...s-demo/src/app/shared/spinner/spinner.component.ts | 100.00% <0.00%> (ø) |
|
...-demo/src/app/features/home/home/home.component.ts | 100.00% <0.00%> (ø) |
|
...emo/src/app/core/layout/footer/footer.component.ts | 100.00% <0.00%> (ø) |
|
... and 40 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 50042e8...ff92b42. Read the comment docs.
@arturovt looks great! 👏 👏 👏
Hey! I've removed Karma & Jasmine and switched to Jest since it's much easier to run tests with it. I'm always having issues with Karma locally, e.g. it can't capture a browser or it terminates the process w/o a reason, this is super annoying and makes TDD harder.
This doesn't bring any breaking change and will only make developers happy since Jest is more powerful comparing to Jasmine, e.g. watching specific file, etc.