search

angular-klingon / klingon

Angular Klingon: The UI companion for the @angular/cli
https://angular.run
MIT License
189 stars 19 forks source link

build: update angular deps to angular#master (@klingon/ui) #57

Closed daniloff200 closed 5 years ago

daniloff200 commented 6 years ago

closes #55

welcome[bot] commented 6 years ago

Thanks for opening this pull request! Please check out our contributing guidelines and coding standards.

manekinekko commented 6 years ago

LGTM. But we need to make sure that the current UI is still in sync with the latest version of angular/cli-builds#master. The CLI commands and flags are currently hardcoded in the UI :/

daniloff200 commented 6 years ago

:roll_eyes: I didn't completely get, what u mean :sos:

Do you mean the angular.json commands in the klingon/ui folder? Can I assist u with that? @manekinekko

manekinekko commented 6 years ago

What I mean is that all the CLI flags are hard coded in the UI, ie. build, server, etc... So updating the CLI to master may break if the hard-coded CLI flags are no more in sync with the latest version.

This rises another issue which is: Hard coding the CLI commands and flags in the UI is not a good approach anymore!

BTW, I'm assuming that the server is using the same CLI version as the UI.

Does that make sense?

daniloff200 commented 5 years ago

I think, right it this PR also can be closed @manekinekko

manekinekko commented 5 years ago

Sorry about that @daniloff200 we had some issues with angular master on other projects. So we had to revert to a fixed version.