search

angular-leap / angular-leap

MIT License
68 stars 4 forks source link

refactor(leapService): provide timeout and gestureIntense #32

Closed robinboehm closed 10 years ago

robinboehm commented 10 years ago

@PascalPrecht I've offered the configuration via provider AND service. I think it should also be possible to change this values in a running app. Also the test-Suite is updated up to 113 tests.

What do you think?

robinboehm commented 10 years ago

@PascalPrecht Similar Issue here: https://github.com/leapmotion/leapjs/issues/126

robinboehm commented 10 years ago

@PascalPrecht I'l merge, okay? That timeout "problem" is another issue:

That special behavior is documented at https://github.com/angular-leap/angular-leap/issues/34

0x-r4bbit commented 10 years ago

@robinboehm Interesting! And a good sign at the same time :) So we probably don't need that timeout stuff in the future :)

0x-r4bbit commented 10 years ago

I think we should merge this now, since more of the commits are going apart from the original intend of this PR.

0x-r4bbit commented 10 years ago

:+1: