angular-material-extensions / google-maps-autocomplete

Autocomplete input component and directive for google-maps built with angular and material design |
https://angular-material-extensions.github.io/google-maps-autocomplete
MIT License
169 stars 60 forks source link

Please support Angular 10 #297

Closed wottpal closed 3 years ago

wottpal commented 3 years ago
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @angular/common@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @angular/core@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @angular/platform-browser@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @angular/flex-layout@^9.0.0-beta.31 but none is installed. You must install peer dependencies yourself.
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @angular/forms@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @angular/cdk@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @angular/material@^9.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @angular-material-extensions/google-maps-autocomplete@4.1.1 requires a peer of @agm/core@^1.1.0 but none is installed. You must install peer dependencies yourself.
zacuke commented 3 years ago

Hi

I forked the project and updated it to tide us over until author can update to angular 10.

Uninstall your current package and run:

npm install https://www.effectivesln.com/angular-material-extensions-google-maps-autocomplete-4.1.1-angular10.tgz

zacuke commented 3 years ago

298

wottpal commented 3 years ago

Really nice, thanks! I just integrated it into my package.json and it works fine :)

Though, there are still two google-maps-autocomplete related warnings.. I don't know if you can do anything about that or if it's the fault of the dependencies:

npm WARN inquirer-autocomplete-prompt@1.0.1 requires a peer of inquirer@^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @phenomnomnominal/tsquery@4.0.0 requires a peer of typescript@^3 but none is installed. You must install peer dependencies yourself.

❯ npm list inquirer-autocomplete-prompt
projectname@1.0.0
└─┬ google-maps-autocomplete@0.0.0 (github:zacuke/google-maps-autocomplete#b3a0f8cd016b72b8da9259a073074953c23c93d7)
  └─┬ @briebug/jest-schematic@3.0.0
    └─┬ @schuchard/schematics-core@0.4.0
      ├── inquirer-autocomplete-prompt@1.0.1 
      └─┬ inquirer-fuzzy-path@2.2.0
        └── inquirer-autocomplete-prompt@0.12.2 

❯ npm list @phenomnomnominal/tsquery   
projectname@1.0.0
└─┬ google-maps-autocomplete@0.0.0 (github:zacuke/google-maps-autocomplete#b3a0f8cd016b72b8da9259a073074953c23c93d7)
  └─┬ @briebug/jest-schematic@3.0.0
    └─┬ @schuchard/schematics-core@0.4.0
      └── @phenomnomnominal/tsquery@4.0.0 
AnthonyNahas commented 3 years ago

v5.0.0 has been just released!

--> support of angular 10 incl.

thanks for contributing 🍻

wottpal commented 3 years ago

Hey @AnthonyNahas, huge thanks for merging and releasing a new version!!

I still get some warnings @5.0.0 (which is didn't get with the fork by @zacuke i think):

npm WARN @angular-material-extensions/google-maps-autocomplete@5.0.0 requires a peer of zone.js@~0.11.1 but none is installed. You must install peer dependencies yourself.

This is the zone.js version for Angular 11, not 10. So this results in a conflict…

Also:

npm WARN @angular-material-extensions/google-maps-autocomplete@5.0.0 requires a peer of @types/googlemaps@3.39.12 but none is installed. You must install peer dependencies yourself.

As it exactly required version 3.39.12 I've fixed that doing by npm i -D @types/googlemaps@3.39.12 – But you should either mention that in the README or depend on ^3.39.12.

Thanks in advance 🙂

AnthonyNahas commented 3 years ago

@wottpal would you please open an appropriate ticket for that. I would consider that for the next release