angular-material-extensions / link-preview

Angular open source UI library to preview web links
https://angular-material-extensions.github.io/link-preview
MIT License
57 stars 18 forks source link

Failed to compile entry-point @angular-material-extensions/link-preview (`es2015` as esm2015) due to compilation errors: #112

Open maifeeulasad opened 3 years ago

maifeeulasad commented 3 years ago

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

OS and Version?

Ubuntu 20.04 LTS

Versions

Angular CLI: 12.0.5
Node: 14.17.4
Package Manager: npm 7.20.6
OS: linux x64

Angular: 12.0.5
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1200.5
@angular-devkit/build-angular   12.0.5
@angular-devkit/core            12.0.5
@angular-devkit/schematics      12.0.5
@angular/cdk                    12.2.5
@angular/http                   7.2.16
@angular/material               12.2.5
@schematics/angular             12.0.5
rxjs                            6.6.7
typescript                      4.2.4

Repro steps

Just added deps in this repo: https://github.com/maifeeulasad/news-update/tree/develop And in the app.module.ts:

  imports: [
    ...
    MatLinkPreviewModule
  ],

The log given by the failure

Error: Failed to compile entry-point @angular-material-extensions/link-preview (`es2015` as esm2015) due to compilation errors:
node_modules/@angular-material-extensions/link-preview/esm2015/link-preview.js:255:26 - error NG1010: Value at position 3 in the NgModule.imports of MatLinkPreviewModule is not a reference
  Value could not be determined statically.

255                 imports: [
                             ~
256                     CommonModule,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
261                     MatProgressSpinnerModule,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
262                 ],
    ~~~~~~~~~~~~~~~~~

  node_modules/@angular-material-extensions/link-preview/esm2015/link-preview.js:259:21
    259                     MatCardModule,
                            ~~~~~~~~~~~~~
    Unknown reference.

Compiling @angular-material-extensions/link-preview : es2015 as esm2015
/home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/execution/tasks/completion.js:57
            throw new Error(createErrorMessage(fs, task, message));
            ^

Error: Failed to compile entry-point @angular-material-extensions/link-preview (`es2015` as esm2015) due to compilation errors:
node_modules/@angular-material-extensions/link-preview/esm2015/link-preview.js:255:26 - error NG1010: Value at position 3 in the NgModule.imports of MatLinkPreviewModule is not a reference
  Value could not be determined statically.

255                 imports: [
                             ~
256                     CommonModule,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
... 
261                     MatProgressSpinnerModule,
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
262                 ],
    ~~~~~~~~~~~~~~~~~

  node_modules/@angular-material-extensions/link-preview/esm2015/link-preview.js:259:21
    259                     MatCardModule,
                            ~~~~~~~~~~~~~
    Unknown reference.

    at /home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/execution/tasks/completion.js:57:19
    at /home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/execution/tasks/completion.js:31:13
    at /home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/execution/create_compile_function.js:69:21
    at SingleProcessExecutorSync.SingleProcessorExecutorBase.doExecute (/home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/execution/single_process_executor.js:36:17)
    at /home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/execution/single_process_executor.js:57:59
    at SyncLocker.lock (/home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/locking/sync_locker.js:34:24)
    at SingleProcessExecutorSync.execute (/home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/execution/single_process_executor.js:57:27)
    at Object.mainNgcc (/home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/src/main.js:74:25)
    at Object.process (/home/maifee/Desktop/news-update/node_modules/@angular/compiler-cli/ngcc/index.js:29:23)
    at NgccProcessor.processModule (/home/maifee/Desktop/news-update/node_modules/@ngtools/webpack/src/ngcc_processor.js:164:16)

Process finished with exit code 1

Desired functionality

Mention any other details that might be useful

Found this issue: https://github.com/angular-material-extensions/link-preview/issues/110. As it doesn't have any solution, I created a new one.

PopePAF commented 2 years ago

Same Problem here... I think this extension is just not ready for angular versions newer than 7... It also has a dependencie to @angular/http which is deprecateed.

see:

  "peerDependencies": {
    "@angular/animations": "^7.1.4",
    "@angular/cdk": "^7.2.0",
    "@angular/common": "^7.1.4",
    "@angular/core": "^7.1.4",
    "@angular/http": "^7.1.4",
    "@angular/material": "^7.2.0",
    "@angular/platform-browser": "^7.1.4"
  }

Also after doing the sae changes like here: https://github.com/angular-material-extensions/link-preview/issues/110#issuecomment-771229502 it did actually work too... so it might not be that difficult to port this extension to newer versions?!