Closed aminpaks closed 7 years ago
I already fixed the issue in angular-redux/store
project, where can I ask for PR?
angular-redux/store
Hey - looking into it now. Please understand that I don't get to everything immediately.
I've reproduced the issue and confirmed that your fix works. Thanks, nice catch!
I also took the liberty of creating a PR with from your fork, here: https://github.com/angular-redux/store/pull/409. There are a couple of minor cleanup items after which I'd be happy to merge it.
I cleaned up the PR and merged it. The fix has been released in @angular-redux/store
6.4.1.
I changed two lines in your example and run it. After about 30,000 actions app accumulates up to 300MB memory and crashes.
These are steps to reproduce this issue:
Update
addTicket
inanimal
component to, this code simulates dispatching many actions to observe the issue easier:Remove the
createLogger
anddevTools enhancer
fromstore/module
:Run the app
yarn start
Click on
+
to start the process: this will dispatch 10000 actions and update the UI.Observe how app crashes after a few times clicking on the plus
You may check the memory in
Chrome devTools
too.