search

angular-redux / form

Keep your Angular2+ form state in Redux
MIT License
41 stars 15 forks source link

Update so it works with Reactive forms #27

Closed GenZodd closed 7 years ago

GenZodd commented 7 years ago

Address issue #22

Tested this locally with the code base that triggered the creation of this issue. Works for template and reactive. Locally the tests will not run but they also do not run with the main GIT master branch so seems to be a local issue. Please review and provide any feedback.

GenZodd commented 7 years ago

@SethDavenport Not sure if you are the right person to bug but what needs to happen to get this reviewed and brought in?

SethDavenport commented 7 years ago

Sorry for the delay on this - I actually haven't been super involved with angular-redux/form - I'm mostly the store and example-app guy. Unfortunately /form needs a new maintainer, and possibly a re-think, as you may have noticed.

My personal take is that we never intended to support the formBuilder stuff; in practice template-driven forms are much more declarative and therefore preferable.

@danielfigueiredo @clbond any thoughts on this change? It seems reasonable to me, but you have more experience with complex forms in Angular than I do.

SethDavenport commented 7 years ago

Give @angular-redux/form@6.5.0 a whirl and let me know.

ghost commented 6 years ago

Still have never gotten this to work. :/ Not once have I even seen a form show up in my state. Are the docs up to date?