search

angular-redux / ng-redux

Angular bindings for Redux
MIT License
1.16k stars 177 forks source link

fix: Replace lodash assign with Object.assign for symbol copy #144

Closed AntJanus closed 7 years ago

AntJanus commented 7 years ago

Ref: #129 #141

Replacement for original #129 solution. I'm replacing lodash's assign with Object.assign which copies over not only object keys/values but also Symbols.

AntJanus commented 7 years ago

@HunterEl can you quickly check out this PR? Just let me know if it makes sense. I tested this locally but since we don't have any ngRedux.spec.js tests, there isn't an easy way to test it other than just using using a console log and using Object.getOwnPropertySymbols.

HunterEl commented 7 years ago

@AntJanus will do!

HunterEl commented 7 years ago

This seems like a very reasonable change. Works for me!