search

angular-redux / ng-redux

Angular bindings for Redux
MIT License
1.16k stars 177 forks source link

Fix: update typings to fit with umd module #155

Closed jrakotoharisoa closed 7 years ago

jrakotoharisoa commented 7 years ago

Now we should be able to import ng-redux v3.5.x UMD module in typescript like this : 

import * as ngRedux from "ngRedux";

Issue #153

AntJanus commented 7 years ago

@jrakotoharisoa awkward question. How do I test that this works as intended?

jrakotoharisoa commented 7 years ago

@AntJanus You can test with this repo : https://github.com/jrakotoharisoa/ng-redux-typescript-test

After a npm install, run npm start. A typescript error occured due to wrong typings of v3.5.0.

Try to use the updated version of ng-redux/index.d.ts then it should works.

AntJanus commented 7 years ago

@jrakotoharisoa 👍 thanks! I'll give that a shot :)