subscribe return type in INgRedux

angular-redux / ng-redux

Angular bindings for Redux

MIT License

1.16k stars 177 forks source link

subscribe return type in INgRedux #172

Closed dawidzq closed 6 years ago

dawidzq commented 6 years ago

Hello,

Is there any reason that the subscribe() function returns a Function in index.d.ts rather than type Unsubscribe (defined inside of 'redux')?

AntJanus commented 6 years ago

@dawidzq I'm not a type guru so I can't answer the question but if you feel like you can fix this issue, please open a PR. I'll merge it in and do a release.

dawidzq commented 6 years ago

@AntJanus I created a PR here: https://github.com/angular-redux/ng-redux/pull/173

Let me know if I did something wrong. This would be my first one. 😄

AntJanus commented 6 years ago

Thanks for the submission! It was merged in.