search

angular-redux / store

Angular 2+ bindings for Redux
MIT License
1.34k stars 205 forks source link

angular 6, redux 4, rxjs 6 #527

Closed actra-gschuster closed 6 years ago

actra-gschuster commented 6 years ago

@leo6104 Changes done by adding a typedoc plugin and specifying the base URL in package.json, otherwise typedoc always uses the github repo automatically and since it's still a pull from my repo the URL would be wrong.

Seems something's wrong with the linter on circleci, running the linter on my windows machine shows no errors and all tests pass, at least when the randomized tests run in correct order ^^

iici-vsimha commented 6 years ago

Any progress on releasing this? We use this package and have a need to go to angular 6 but cannot until have a fix for this. Please help getting this finished.

actra-gschuster commented 6 years ago

I don't know what's the matter on CircleCI, lint and tests pass perfectly on my system.

@SethDavenport any chance to have a look soon

test-rdxstr

actra-gschuster commented 6 years ago

@iici-vsimha I finally got CI fixed, waiting for review and merge.

iici-vsimha commented 6 years ago

Thank you very much. This is of great help!!

Regards, Vikram

Vikram Simha Founder & CEO, Informatics In Context, Inc. Ph : (781) 696-0827 One Boston Place, Suite 2600 Web: http://informaticsincontext.com/ Boston, MA 02108

This e-mail message, including any attachment, is privileged and confidential and is intended only for the recipient(s) listed above. If you are neither the intended recipient(s) nor a person responsible for the delivery of this email to the intended recipient(s), you are hereby notified that any unauthorized distribution or copying of this email is prohibited. If you receive this email in error, please notify Informatics In Context, Inc. immediately via email at info@informaticsincontext.commailto:info@informaticsincontext.com or by phone at (857) 400-8990.

On May 24, 2018, at 9:37 AM, Gabriel Schuster notifications@github.com<mailto:notifications@github.com> wrote:

@iici-vsimhahttps://github.com/iici-vsimha I finally got CI fixed, waiting for review and merge.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/angular-redux/store/pull/527#issuecomment-391717481, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AG7X5fNEJR_vc9j-nnlNbgx6v4UmbMTUks5t1reegaJpZM4T-5VG.

SethDavenport commented 6 years ago

Sorry for the delay. Taking a look now.

SethDavenport commented 6 years ago

oh right.