NgRedux<RootState> - Githubissues

v-miguez commented 5 years ago

This is a...

[ ] feature request
[ ] bug report
[ ] usage question

What toolchain are you using for transpilation/bundling?

[ ] @angular/cli
[ ] Custom @ngTools/webpack
[ ] Raw ngc
[ ] SystemJS
[ ] Rollup
[ ] Other

Environment

NodeJS Version: Typescript Version: Angular Version: @angular-redux/store version: @angular/cli version: (if applicable) OS:

Link to repo showing the issus

(optional, but helps a lot)

Expected Behaviour:

Actual Behaviour:

Stack Trace/Error Message:

Additional Notes:

(optional)

sachin27sharma commented 5 years ago

Hi,

Am getting below error when i upgraded to angular 7.1.1, using "@angular-redux/store": "^10.0.0",

ERROR in node_modules/@angular-redux/store/components/ng-redux.d.ts(10,31): error TS2420: Class 'NgRedux' incorrectly implements interface 'ObservableStore'. Property '[Symbol.observable]' is missing in type 'NgRedux'.

These are the versions in my package.json -
"@angular-redux/store": "^10.0.0", "@angular/core": "^7.1.1", "redux": "^4.0.4", "rxjs": "^6.3.3",

peerDepencies for @angular-redux/store@10.0.0 are this - So my above packages are meeting the criteria but still getting the error.

npm view @angular-redux/store@10.0.0 peerDependencies { '@angular/core': '^7.0.0', redux: '^4.0.0', rxjs: '^6.0.0' }

MartinJHammer commented 5 years ago

@sachin27sharma "@angular-redux/store": "^10.0.0", and "redux": "^4.0.4", doesn't play well together. Downgrade redux to "redux": "^4.0.1" and the error should dissappear.

MiHawkStackOverFlow commented 5 years ago

I am facing the same issue when I tried to upgrade from Angular7 to Angular8.

../node_modules/@angular-redux/store/components/ng-redux.d.ts:10:31 - error TS2420: Class 'NgRedux' incorrectly implements interface 'ObservableStore'. Property '[Symbol.observable]' is missing in type 'NgRedux' but required in type 'ObservableStore'.

My package json is as follows:-

"dependencies": { "@angular-redux/store": "^9.0.0", "@angular/animations": "^8.2.0", "@angular/cdk": "^8.1.2", "@angular/common": "^8.2.0", "@angular/compiler": "^8.2.0", "@angular/core": "^8.2.0", "redux": "^4.0.4", "@types/redux": "3.6.0" }

@MartinJHammer When i tried to use "@angular-redux/store": "^10.0.0", and "redux": "^4.0.1". I get one more error

ERROR in ../node_modules/@angular-redux/store/components/dev-tools.d.ts:3:33 - error TS2307: Cannot find module 'redux-devtools-extension'.

3 import { EnhancerOptions } from 'redux-devtools-extension';

With "@angular-redux/store": "^9.0.0", and "redux": "^4.0.1", I get only one error which is Property '[Symbol.observable]' is missing in type 'NgRedux' but required in type 'ObservableStore'.

MartinJHammer commented 5 years ago

@MiHawkStackOverFlow Hmmm... Hard to say what is wrong then. Maybe your redux configuration is off? Maybe you need to use a different rxjs version? Or maybe try "Hard" dep versions e.g. ""redux": "4.01" instead of "redux": "^4.0.1". With the '^' you risk a higher version being installed than you expected. Try checking your package-lock.json to see exactly what has been installed. It's a long file, so I recommend using search in the file.

sachin27sharma commented 5 years ago

Thanks Martin. Will give this a try.

houyaowei commented 5 years ago