angular-sanctuary / angular-hub

Curated list of Angular events and communities
https://angular-hub.com/
MIT License
49 stars 30 forks source link

[Bug]: Invalid URL #232

Closed eduardoRoth closed 4 months ago

eduardoRoth commented 4 months ago

Relevant scope

angular application

Description

I just cloned the repo, ran npm ci and then npm run start and when the app loads I get the following error in console:

ERROR TypeError: Invalid URL
    at new URL (node:internal/url:814:29)
    at load (/Users/eduardoroth/webapps/angular-hub/node_modules/@analogjs/router/fesm2022/analogjs-router.mjs:91:29)
    at eval (/Users/eduardoroth/webapps/angular-hub/node_modules/@angular/router/fesm2022/router.mjs:4141:78)
    at Module.runInInjectionContext (/Users/eduardoroth/webapps/angular-hub/node_modules/@angular/core/fesm2022/core.mjs:3405:16)
    at getResolver (/Users/eduardoroth/webapps/angular-hub/node_modules/@angular/router/fesm2022/router.mjs:4141:33)
    at eval (/Users/eduardoroth/webapps/angular-hub/node_modules/@angular/router/fesm2022/router.mjs:4132:90)
    at doInnerSub (/Users/eduardoroth/webapps/angular-hub/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:22:31)
    at outerNext (/Users/eduardoroth/webapps/angular-hub/node_modules/rxjs/dist/cjs/internal/operators/mergeInternals.js:17:70)
    at OperatorSubscriber._this._next (/Users/eduardoroth/webapps/angular-hub/node_modules/rxjs/dist/cjs/internal/operators/OperatorSubscriber.js:33:21)
    at Subscriber.next (/Users/eduardoroth/webapps/angular-hub/node_modules/rxjs/dist/cjs/internal/Subscriber.js:51:18) {
  code: 'ERR_INVALID_URL',
  input: ''
}

Do you want to contribute with a pull request?

Yes

geromegrignon commented 4 months ago

Hello @eduardoRoth, I could not reproduce it even by deleting node_moduels but by cloning it in another folder i get the same problem.

eduardoRoth commented 4 months ago

@geromegrignon , maybe there's some stuff missing that got deleted in a previous PR?

geromegrignon commented 4 months ago

@eduardoRoth I found out the issue. The project is a fullstack SSR Analog application using data prefetching.

It requires an .env file with VITE_ANALOG_PUBLIC_BASE_URL="http://localhost:4200" as a value. That's the difference I have.

The README should be updated with that information.

eduardoRoth commented 4 months ago

Great! I'll create a PR with that update on the README.md file