Wrong default value for `cname` in `schema.json`

angular-schule / angular-cli-ghpages

🚀 Deploy your 🅰️Angular app to GitHub pages, Cloudflare Pages or any other Git repo directly from the Angular CLI! Available on NPM.

https://www.npmjs.com/package/angular-cli-ghpages

MIT License

951 stars 96 forks source link

Wrong default value for `cname` in `schema.json` #154

Closed JohannesHoppe closed 1 year ago

JohannesHoppe commented 2 years ago

Error: Property 'cname' does not match the schema. 'false' should be a 'string'.

Solved it by adding cname flag manually as github.com along with base-href.

Originally posted by @batbrain9392 in https://github.com/angular-schule/angular-cli-ghpages/issues/145#issuecomment-1050404723

see https://github.com/angular-schule/angular-cli-ghpages/blob/76753b0dcd66e4b09007c6dd4bf0615ebc8a488f/src/deploy/schema.json#L51-L55

JohannesHoppe commented 2 years ago

The typings here are indeed wrong, an empty string should do the trick.