search

angular-schule / angular-cli-ghpages

🚀 Deploy your 🅰️Angular app to GitHub pages, Cloudflare Pages or any other Git repo directly from the Angular CLI! Available on NPM.
https://www.npmjs.com/package/angular-cli-ghpages
MIT License
951 stars 96 forks source link

Missing 404.html when deploying localized Angular 18 app #192

Open sondreb opened 3 months ago

sondreb commented 3 months ago

I have an Angular 18 app that I've added the standard i18n (internationalization) support for Angular.

This means the output of my app are multiple folders with copies of the same app, in different languages.

When I now run deploy using this package, it no longer generates the 404 (not on root and not within the language folders).

Is there some option or something to make it work with localization?

JohannesHoppe commented 3 months ago

We haven't changed any details here, the 404.html is still created?!

sondreb commented 3 months ago

When moving from a single language to multi language app, it outputs "en", "no", "fr" sub-folders, each individual copies of the whole app. When doing the deploy, it doesn't create any 404 anymore (after I added multiple languages).

JohannesHoppe commented 3 months ago

I see your point. The command wont copy the index.html to 404.html because it can't find it. There should be a warning message about this. Do you think you can come up with a solution for this? First we should recognise the different folder structure, then we should copy all the index.html files. PRs are highly welcome! 👍