angular-schule / ngx-deploy-starter

Starter repository to create a new builder to utilize the `ng deploy` command 🚀
https://www.npmjs.com/package/@angular-schule/ngx-deploy-starter
MIT License
54 stars 30 forks source link

Refactor Build #29

Open JohannesHoppe opened 3 years ago

JohannesHoppe commented 3 years ago

What about of having two separate package.json files?

One outside the src folder for development that will contain all the development stuff (test, build, lint, prettier, publishing, etc) and the other one inside src that would be the one that is going to be on the dist.

Personally it's little bit frustrating having the package.json inside the src folder, I always forget to step into the right folder to execute npm install.

I think with this movement will rise my development satisfaction.

Originally posted by @dianjuar in https://github.com/angular-schule/ngx-deploy-starter/issues/28#issuecomment-744198379

JohannesHoppe commented 3 years ago

Ideas:

  1. two separate package.json files --- that's fine for me, too
  2. symbolic link to avoid 2x README --- this seems to be a bit complicated, I would vote for one README on root folder that is copied during build
  3. new idea: refactor build steps to a new file build.js, because it's super hard to read everything in one line

@dianjuar

JohannesHoppe commented 3 years ago

@dianjuar I invited you as a collaborator, so that we can work together on a single branch/PR.

dianjuar commented 3 years ago

I started the first point, but I think we need to discuss some stuff about it. Every point has its implications and special discussion that it's better to take down them independently.

I think we can do the following:

  1. I think the best approach to do this is having a "master-branch" to improve the build, do individual PRs for every point to that "master-branch" to have at the end one nice PR to integrate
  2. Individual PR's to master

What do you think about this? Do you have a different approach in mind?

JohannesHoppe commented 3 years ago

option 1 sounds great! 👍

The "Collaborator" badge suits you very well, too! 😄