search

angular-slider / angularjs-slider

Slider directive for AngularJS 1.X. No dependencies and mobile friendly.
http://angular-slider.github.io/angularjs-slider
MIT License
1.23k stars 498 forks source link

Add 'slideChanged' event #664

Closed marlais closed 5 years ago

marlais commented 5 years ago

By adding a 'slideChanged' event to the callOnChange function, you're giving the user scope a much easier way to detect slider updates than having to listen to the local variable manually. I personally found this useful in my project, but I would rather not modify the source code on your project.

codecov-io commented 5 years ago

Codecov Report

Merging #664 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #664   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines        1004   1004           
=====================================
  Hits         1004   1004

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e657948...2d39d32. Read the comment docs.

ValentinH commented 5 years ago

Hello, Thanks for this PR.

You don't need to listen to the local variable, you can simply use the onChange callback. Do you need something else?

ValentinH commented 5 years ago

Closing as there was no answer for a while. Comment to re-open 😉