angular-ui / AngularJS-Atom

An AngularJS package for Github's Atom editor
https://atom.io/packages/angularjs
MIT License
284 stars 49 forks source link

Provide angular semantic highlighting. #26

Closed ghost closed 9 years ago

ghost commented 9 years ago

Currently atom does not properly highlight "{{scope.myvar}}", it highlights everything the string color. And inside ng attributes

  <span ng-show="transaction.paymentAmount !=== undefined">C</span>

WebStorm handles angular highlighting nicely.

outsideris commented 9 years ago

2015-04-19 19 42 32

Now, syntax highlighting for expressions looks like above. Did you use document type as "HTML(Angular)"

ghost commented 9 years ago

No doctype is just HTML when ng-app in body. I have partial templates with no doctype defined.

On Sun, Apr 19, 2015, 3:45 AM JeongHoon Byun (aka Outsider) < notifications@github.com> wrote:

[image: 2015-04-19 19 42 32] https://cloud.githubusercontent.com/assets/390146/7219124/607b3a3c-e6cc-11e4-8075-4056d460d22b.png

Now, syntax highlighting for expressions looks like above. Did you use document type as "HTML(Angular)"

— Reply to this email directly or view it on GitHub https://github.com/angular-ui/AngularJS-Atom/issues/26#issuecomment-94262707 .

outsideris commented 9 years ago

2015-04-20 11 43 43

I means Atom's document type, not HTML doctype. See right of bottom in above screenshot. HTML is default for .html. So, this package support HTML (Angular).

kraila commented 9 years ago

I was just trying to figure this out myself. Thanks! I didn't think to check the Atom doctype.

outsideris commented 9 years ago

@KellyTeresa Good!