search

angular-ui / AngularJS-Atom

An AngularJS package for Github's Atom editor
https://atom.io/packages/angularjs
MIT License
284 stars 49 forks source link

Merge atom-angularjs #3

Closed outsideris closed 10 years ago

outsideris commented 10 years ago

Merged from atom-angularjs package.

outsideris commented 10 years ago

@ProLoser This is my first pull request after I joined augular-ui team. Can I merge this myself or somebody will review and merge?

ProLoser commented 10 years ago

Alright I provided lots and lots of feedback for you to consider, but otherwise feel free to merge this yourself whenever you're comfortable with it.

ProLoser commented 10 years ago

I'd also suggest trying out some of the stuff in this original version before you merge to see how you feel about it or how it works for you.

outsideris commented 10 years ago

I updated my pull request. I'm really glad you post lots feedback for my code. It's first time we work together. so I think we have to understand each other and discuss which direction the package choose. Feedback is always welcome. thank you.