search

angular-ui / AngularJS-Atom

An AngularJS package for Github's Atom editor
https://atom.io/packages/angularjs
MIT License
284 stars 49 forks source link

Package.getStylesheetsPath is deprecated. #34

Closed mrenfinger closed 9 years ago

mrenfinger commented 9 years ago

Store package style sheets in the styles/ directory instead of stylesheets/ in the angularjs package

Package.getStylesheetsPath (/Users/michaelenfinger/Desktop/Atom.app/Contents/Resources/app.asar/src/package.js:464:9)
Package.getStylesheetPaths (/Users/michaelenfinger/Desktop/Atom.app/Contents/Resources/app.asar/src/package.js:475:32)
Package.loadStylesheets (/Users/michaelenfinger/Desktop/Atom.app/Contents/Resources/app.asar/src/package.js:457:38)
<unknown> (/Users/michaelenfinger/Desktop/Atom.app/Contents/Resources/app.asar/src/package.js:187:19)
jfelixetcetera commented 9 years ago

Fixed in 0.2.0. Not sure why automatic upgrade isn't working, but it can be upgraded manually with apm install angularjs@0.2.0.

seronal commented 9 years ago

I think this had to with this property in package.json:

  "engines": {
    "atom": ">=0.174.0, <2.0.0"
  },

">=0.174.0, <2.0.0" does not seem to be a valid range, so the following was returning false

semver.satisfies('0.200.0', '>=0.174.0, <2.0.0')

I just created a PR to fix this.

outsideris commented 9 years ago

I expect It fixed in #39 . I will publish new version.