angular-ui / AngularJS-Atom

An AngularJS package for Github's Atom editor
https://atom.io/packages/angularjs
MIT License
284 stars 49 forks source link

Autocompletion box opens everytime #83

Open tiagomsmagalhaes opened 6 years ago

tiagomsmagalhaes commented 6 years ago

On javascript file, after every character it appears suggestions from your plugin which is counter productive working like that. Even with a space triggers the box with all the suggestions

outsideris commented 6 years ago

I didn't realize that. I have an idea why that happened.I will check it.

Autalyst commented 6 years ago

I am getting this too, but mostly with commas. Every time I have a comma it tries to autocomplete and then I end up with a lot of garbage because I'm trying to put in a new line.

FrEaKmAn commented 6 years ago

Yes, same problem here. Super annoying

Sparksx commented 6 years ago

Same problem

gmanriqueUy commented 6 years ago

Same here:

angularjs-atom-bug

Thanks!

outsideris commented 6 years ago

I just released v0.5.2. Please check it again.

Sparksx commented 6 years ago

Fixed for me in v0.5.2

Thanks @outsideris

tiagomsmagalhaes commented 6 years ago

@outsideris updated the plugin and still appears everytime

EDITED: updated the plugin and still appears everytime as soon I press space

Autalyst commented 6 years ago

It appears to be resolved for me in v0.5.2

outsideris commented 6 years ago

@tiagomsmagalhaes Could you explain more details? Others said it is fixed. OS or Atom versions?

tiagomsmagalhaes commented 6 years ago

@outsideris comma doesn't trigger suggestions but spacebar does.

Windows 10 Atom 1.23.2 x64

Package list from apm: angularjs@0.5.2 atom-clock@0.1.15 atom-live-server@2.2.0 atom-typescript@11.0.10 autocomplete-angular-material@0.4.0 busy-signal@1.4.3 editorconfig@2.2.2 emmet@2.4.3 file-icons@2.1.15 git-clone@0.2.0 git-plus@7.10.0 intentions@1.1.5 linter@2.2.0 linter-ui-default@1.6.10 multi-cursor@2.1.5 zip-folder@3.2.0

outsideris commented 6 years ago

@tiagomsmagalhaes I got it. Thank you.

dierol commented 6 years ago

Works fine in v0.5.2. Thanks for this fix! It was an ungodly annoying behavior.

tiagomsmagalhaes commented 6 years ago

@outsideris Updated to 0.5.3 Still happens...

Use cases:

Sparksx commented 6 years ago

You should hide it with "non word characters" (look at: atom > preference > editor) by default it's set to: /()"':,.;<>~!@#$%^&*|+=[]{}`?-… suggestion have no sense after these characters, except after dot?

tiagomsmagalhaes commented 6 years ago

@Sparksx you replied to me or @outsideris?

Either way, I have that default non word characters with the default set. But that only works on html (angular) files. on js files the use cases i listed occurs.

Sparksx commented 6 years ago

I replied to @outsideris

I've same problem that you @tiagomsmagalhaes

outsideris commented 6 years ago

hmm Now I just checking characters but I should determine with context. I will dig it.