angular-ui / bootstrap-bower

This is a bower repository to hold Angular UI Bootstrap releases.
http://angular-ui.github.com/bootstrap/
158 stars 326 forks source link

Bower install referencing ui-bootstrap-tpls.min.js missing templates #20

Closed unclejustin closed 10 years ago

unclejustin commented 10 years ago

This doesn't seem to be working for me. I am referencing bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js after installing via bower and I get missing template files errors until I download the template directory from github.

According to this issue https://github.com/angular-ui/bootstrap-bower/issues/9 I should not need to download the templates folder separately.

pkozlowski-opensource commented 10 years ago

@unclejustin could you please provide a minimal reproduce scenario using http://plnkr.co/ ? What you are saying doesn't sound right but it is hard to pin-point the exact issue without seeing the exact setup on your end. I suspect that you are not referencing ui.bootstrap as a module dependency, but this is just a guess atm.

unclejustin commented 10 years ago

It's going to be hard to do since it is only failing when I actual install from bower. Here's the plunk I was using to troubleshoot, but it actually works. It's pretty simple to recreate on my local though. I run bower install angular-bootstrap then include <script src="bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js"></script>

Module: var arc = angular.module('arc', ['ngResource', 'ngCookies', 'ngSanitize', 'ui.bootstrap', 'ui.router', 'ui.validate', 'ui.sortable']);

When I poke around in the tpls file I don't see any references to template cache. I'm wide open to the fact that I am borking something here, but I don't see where yet.

http://plnkr.co/edit/Sjfb3Esx1NsjwaYGLMGZ?p=preview

pkozlowski-opensource commented 10 years ago

@unclejustin this is really weird since if you look at this file: https://raw.github.com/angular-ui/bootstrap-bower/master/ui-bootstrap-tpls.min.js and search for $templateCache there are references to it. I really having hard time to explain what is going on on your end...

unclejustin commented 10 years ago

Gah you're totally right and I found it. I had caching disabled in Chrome dev tools while since I was working on a custom directive earlier. Turned caching back on and everything is fine. Thanks for your help @pkozlowski-opensource

ervbsankar commented 9 years ago

when i deploy my code to production servers, how do i enable caching for browsers?

unclejustin commented 9 years ago

@ervbsankar you can't. It's a setting on the user's local machine.