search

angular-ui / bootstrap-bower

This is a bower repository to hold Angular UI Bootstrap releases.
http://angular-ui.github.com/bootstrap/
158 stars 326 forks source link

Rename component.json to bower.json #4

Closed aeby closed 11 years ago

meenie commented 11 years ago

+1

pkozlowski-opensource commented 11 years ago

@aeby why did you feel like you need to replace CRLF by LF? Was it causing any particular problems? I'm not saying this change is bad, just trying to understand the motivation here...

aeby commented 11 years ago

@pkozlowski-opensource I like normalized line endings and have this setting in my .gitattributes ( * text=auto). If you like I can revert those changes but afaics LFs are used in angular.js and many other projects.

pkozlowski-opensource commented 11 years ago

@aeby OK, I see your point regarding the line endings, we are going to address this directly in the source code: https://github.com/angular-ui/bootstrap/issues/423

Since your PR had 2 changes in one commit I've renamed it myself in a2b1b33eae1cbca1349f849af8ed849fee7b9421. Thnx for the heads up!