search

angular-ui / bootstrap-bower

This is a bower repository to hold Angular UI Bootstrap releases.
http://angular-ui.github.com/bootstrap/
158 stars 326 forks source link

component.json confusing bower? #6

Closed MicahElliott closed 11 years ago

MicahElliott commented 11 years ago

Hi. Thanks for working on getting this to work with bower. I see that you just added the bower.json file, I'm guessing to address details here: https://github.com/angular-ui/bootstrap/issues/56. I'm trying out brunch/bower and see that when I point a new top-level project's bower.json at this repo bower doesn't suck in the bootstrap-bower/bower.json, but does get the component.json and flags a warning.

So my guess is that component.json needs to be removed (is it useful for something else?). When I cloned this, and locally removed the component.json, bower did the right thing by bringing in the bower.json and not warning.

The other important missing bit is that the bower.json appears to need a main key that looks like:

"main": ["./ui-bootstrap-tpls.js", "./ui-bootstrap.js"]

You probably don't care about brunch, but AFAICT it would be helpful to bower to remove component.json and add the main clause to bower.json.

pkozlowski-opensource commented 11 years ago

@MicahElliott thnx a lot for bringing this up. The component.json was left accidentally - my git-fu wasn't quite right yesterday...

I've also added the main section - only one file is necessary though, check details of the various file types we are distributing: https://github.com/angular-ui/bootstrap/tree/gh-pages#build-files

MicahElliott commented 11 years ago

Awesome, Pawel. I just started playing with Bower so wasn't sure if I might be missing something. I appreciate the fix and the education.