search

angular-ui / bootstrap-bower

This is a bower repository to hold Angular UI Bootstrap releases.
http://angular-ui.github.com/bootstrap/
158 stars 326 forks source link

dependency on bootstrap? #8

Closed lanterndev closed 11 years ago

lanterndev commented 11 years ago

https://github.com/angular-ui/bootstrap-bower/blob/master/bower.json currently has:

    "dependencies": {
        "bootstrap": ">=2",

But http://angular-ui.github.io/bootstrap/ says:

no dependency on jQuery or Bootstrap's JavaScript is required. The only required dependencies are:

  • AngularJS (minimal version 1.0.4 or 1.1.2)
  • Bootstrap CSS

This pulls in the entire bootstrap package (almost 300 files, including all the unneeded html, images, less, and in particular javascript). But is this just for the one bootstrap.css file it includes? If so, would it make more sense to leave this up to users, as this is not universally desirable? For instance, if you're using https://github.com/yeoman/generator-angular and answered (the default) "yes" to use compass-twitter-bootstrap, your app's compass-compiled css already has the bootstrap styles included, and you really don't need it duplicated in the Twitter Bootstrap bower package.

pkozlowski-opensource commented 11 years ago

Woooops, I don't know how this happened! Aha, looking at the history it was changed in c93d30c87e3da1b3543e96ac540a55652ed39021

@ProLoser Dean, what was the reasoning behind this change? I agree with @skivvies that this is a bit hard on people provided that we advertise no jQuery / bootstrap JS dependency. I would be for removing those dependencies.

ProLoser commented 11 years ago

This project relies on bootstrap css but I won't argue if you guys want to remove it. I would not remove the angular dependency though. On Jun 25, 2013 1:08 PM, "Pawel Kozlowski" notifications@github.com wrote:

Woooops, I don't know how this happened! Aha, looking at the history it was changed in c93d30chttps://github.com/angular-ui/bootstrap-bower/commit/c93d30c87e3da1b3543e96ac540a55652ed39021

@ProLoser https://github.com/ProLoser Dean, what was the reasoning behind this change? I agree with @skivvies https://github.com/skivviesthat this is a bit hard on people provided that we advertise no jQuery / bootstrap JS dependency. I would be for removing those dependencies.

— Reply to this email directly or view it on GitHubhttps://github.com/angular-ui/bootstrap-bower/issues/8#issuecomment-20003365 .

lanterndev commented 11 years ago

Thanks, @pkozlowski-opensource! Think it's worth making a point-release with this change in it?

pkozlowski-opensource commented 11 years ago

@skivvies I've forced update of the git history (I know, this is bad...) so no need to push a new version.

lanterndev commented 11 years ago

I like that attitude! I was more talking about the bower release though; when I bower install angular-bootstrap it still pulls the bootstrap dependency. Will bower let you overwrite the 0.4.0 release with a new one?

fyockm commented 10 years ago

Can we find some way to list the bootstrap.css as a dependency in bower.json, without requiring the whole project (and accompanying dependencies)?

pkozlowski-opensource commented 10 years ago

@fyockm I would love to have dependency on the CSS part of the bootstrap only, but AFAIK bootstrap is not pushing only CSS as a bower component, unless something have changed. If there is an official CSS-only dependency that I could use I would love to switch to using it!

fyockm commented 10 years ago

I could find no official bootstrap CSS-only dependency. So, I put together a css-only bootstrap package for bower, appropriately named bootstrap-css-only. I know it's not twitter official, but hopefully you will consider using it.

ProLoser commented 10 years ago

I'm warry about using an individuals manually-maintained repo such as this since, if you lose interest or change projects, we're fucked.

On Fri, Oct 18, 2013 at 11:15 AM, Drew Fyock notifications@github.comwrote:

I could find no official bootstrap CSS-only dependency. So, I put together a css-only bootstrap package for bower, appropriately named bootstrap-css-only https://github.com/fyockm/bootstrap-css-only. I know it's not twitter official, but hopefully you will consider using it.

— Reply to this email directly or view it on GitHubhttps://github.com/angular-ui/bootstrap-bower/issues/8#issuecomment-26617428 .

Dean J Sofer DeanSofer@gmail.com

BS Computer Information Systems California State Polytechnic University, Pomona Telephone: 714-900-2254 Website: www.DeanSofer.com Github: github.com/ProLoser

fyockm commented 10 years ago

I understand your hesitation. I'll work on an automated solution for the future. However, I must disagree that you would be "fucked" if for some reason I stop maintaining the repo. Could you not simply remove the dependency in your bower.json at that time? Another option would be for you to host your own bootstrap css-only repo.