search

angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!
http://angular-ui.github.io/bootstrap/
MIT License
14.28k stars 6.73k forks source link

No indication that a bower install in not enough #2622

Closed stephaneeybert closed 9 years ago

stephaneeybert commented 10 years ago

It would be nice if there was a note explicitly stating that the css file needs to be added in the index.html file. The bower install does not take care of this. The bower install only inserts the js include statement.

cheshire137 commented 10 years ago

The bower install I just did didn't insert anything into my HTML file, actually, and I can't find the JS files mentioned in the README that I need to manually include. From the bower install output:

bower angular-ui-bootstrap#*     invalid-meta angular-ui-bootstrap is missing "main" entry in bower.json
bower angular-ui-bootstrap#*     invalid-meta angular-ui-bootstrap is missing "ignore" entry in bower.json

My Grunt output:

angular-ui-bootstrap was not injected in your file.
Please go take a look in "/Users/me/code/my-app/bower_components/angular-ui-bootstrap" for the file you need, then manually include it in your file.
stephaneeybert commented 10 years ago

I'm surprised you did a bower angular-ui-bootstrap. Personally I did a bower angular-bootstrap. Was I wrong ? After manually adding the .css file in my index.html file it works fine though.

stephaneeybert commented 10 years ago

My bower.json file only contains the following bootstrap entry: "angular-bootstrap": "~0.11.0"

Should that be enough ?

pkozlowski-opensource commented 10 years ago

Installation instructions are here: https://github.com/angular-ui/bootstrap#installation and those clearly mention bower command: bower install angular-bootstrap.

As for dependencies on CSS - the trouble is that bootstrap doesn't publish CSS alone as a separate artefact. So adding dependencies on the whole bootstrap package would drag all the Bootstrap's JavaScript and jQuery dependency and it would be even more confusing for the users as this project doesn't require any of the mentioned JavaScript dependencies.

@stephaneeybert @moneypenny if you guys can think of the doc update that could make it clear I would be happy to merge a PR. Thnx!

stephaneeybert commented 10 years ago

Thanks for the clarification. The "As for..." paragraph would be cool on the installation page.

stephaneeybert commented 10 years ago

Sorry, my Git experience is limited, I wonder what a PR is for example.

pkozlowski-opensource commented 10 years ago

@stephaneeybert PR = https://help.github.com/articles/using-pull-requests

stephaneeybert commented 9 years ago

I'm coming back to this, stumbling on the missing css resource, biting me. I can't see anything about it in the doc now.

stephaneeybert commented 9 years ago

What was needed was the following command: bower install bootstrap -s And adding the following statement in the app/index.html file:

goldcaddy77 commented 9 years ago

@stephaneeybert - You actually need to bower install angular-bootstrap. I've put in a PR for this: #3521. Then you just need to include a script tag referencing "angular-bootstrap/ui-bootstrap-tpls.js"