search

angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!
http://angular-ui.github.io/bootstrap/
MIT License
14.27k stars 6.73k forks source link

Carousel broken with Angular 1.4.3 + UI-Bootstrap 0.13.2 + ng-animate + modal dialog #4119

Closed alpeshgaglani closed 9 years ago

alpeshgaglani commented 9 years ago

I'm aware of the issue #3811 , and have the latest fixes from master. The carousel works just fine outside of a dialog box. However, when I use ngAnimate inside a $modal dialog, I see just the first slide. The navigation anchors are hidden, and I cant move to the second slide. Any ideas?

wesleycho commented 9 years ago

Looks like you are correct to a degree, I am able to reproduce here incorrect behavior of a different nature.

wesleycho commented 9 years ago

Ah, now I see the behavior you describe (Plunker was behaving weird for me there).

wesleycho commented 9 years ago

Investigating this, this appears to be a problem with the modal service, and it not being converted to handle $animateCss support. There seems to be some interplay problems between the two due to the new restrictions in ngAnimate.

wesleycho commented 9 years ago

This should be fixed in master now - thanks a lot for this find, I almost cut a new release today before encountering this issue (& the tooltip/popover one).

I highly recommend checking out the comments in #4121, it is highly relevant if you're living on the edge :) .