Modal focus should wait after animation.

angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!

http://angular-ui.github.io/bootstrap/

MIT License

14.29k stars 6.73k forks source link

Modal focus should wait after animation. #4274

Closed wawyed closed 9 years ago

wawyed commented 9 years ago

When a modal is opened focus to either the modal or the autofocus element is applied after waiting a $digest cycle using modalRender property. That is not enough as the focus happens before/during the animation in class. This could be avoided by using the promise returned from $animateCss or $animate.

I could submit a PR if you thing that is the right approach.

wesleycho commented 9 years ago

This sounds reasonable - feel free to file a PR for this.