search

angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!
http://angular-ui.github.io/bootstrap/
MIT License
14.29k stars 6.73k forks source link

Usage of classNameFilter #4404

Closed Aknilam closed 9 years ago

Aknilam commented 9 years ago

Until version without using ngAnimate, it was possible to use $animateProvider.classNameFilter(/animate/) (this line increased page speed noticeably). It would be great if it was still available in actual code.

wesleycho commented 9 years ago

Can you explain clearly what you mean? Do you mean until ngAnimate was used? Nothing is stopping you from using $animateProvider.classNameFilter - this sounds more like a user error than anything else.

Aknilam commented 9 years ago

Ok, I see now it wasn't clear message. Sorry.

Previously you didn't use ngAnimate, but my app did. So I was able to use $animateProvider.classNameFilter(/animate/); line and everything animated properly.

Now I'm migrating to a newer Angular version. After changing library files, accordions and collapse stopped working. I found that above code line was the problem: http://plnkr.co/edit/uGjQzKCy6hrj0V8MVBxD?p=preview (comment/uncomment line 4 in example.js).

Is it your library's problem or angular-animate's problem that it doesn't add /animate/ while running animateCss or should it work in this way?

wesleycho commented 9 years ago

We use the $animate service, so it defaults to how Angular handles it with and without ngAnimate. This is how it should work.

Closing as a misunderstanding.