search

angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!
http://angular-ui.github.io/bootstrap/
MIT License
14.29k stars 6.73k forks source link

Need to create separate karma.conf.js files for testing library with and without jQuery #5737

Open icfantv opened 8 years ago

icfantv commented 8 years ago

See #5720 for some minor background, but core angular has separate tests for with jquery and without and we should update our karma.conf.js files to test with both.

Following the pattern set by angular, we should create a karma-shared file and then defile a jqlite and full-blow jquery one.

wesleycho commented 8 years ago

This requires more work than just that - our tests assume the presence of jQuery, so various tests and helper methods would need to be rewritten for both situations.

Along those lines, we probably also need separate karma files for when ngAnimate is present or not, giving us 4 different karma files we'd need.

icfantv commented 8 years ago

aw damn....nice buzz kill @wesleycho....

wesleycho commented 8 years ago

Just letting you know what work needs to be done upfront :)