search

angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!
http://angular-ui.github.io/bootstrap/
MIT License
14.29k stars 6.73k forks source link

'uibAccordionHeading', can't be found #6293

Closed nrsedat closed 7 years ago

nrsedat commented 7 years ago

Bug description: Upgrading to 2.x.x from 1.3.3 breaks accordion

Link to minimally-working plunker that reproduces the issue: https://plnkr.co/edit/C3YKIAPR6RnEhLZfUo9I?p=preview

Version of Angular, UIBS, and Bootstrap

Angular: 1.5.8

UIBS: 2.2.0

Bootstrap: 3.3.7

pkozlowski-opensource commented 7 years ago

uib-accordion-group can only be used as an attribute and not as an element: https://github.com/angular-ui/bootstrap/blob/997813f0eba41971c948d0ea4c9c9c21542bccd7/src/accordion/accordion.js#L61

nrsedat commented 7 years ago

yes, I saw this. I think this would need me to change every place I use accordion. Is there any reason why element support was removed?

pkozlowski-opensource commented 7 years ago

Is there any reason why element support was removed?

3819bbe8fafe9117d3c9033ef3156803b9a57247

nrsedat commented 7 years ago

Closing this issue as per the above comments