angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!
http://angular-ui.github.io/bootstrap/
MIT License
14.29k stars 6.73k forks source link

Bug in ui.bootstrap.modal #6368

Closed Zadvornyi closed 7 years ago

Zadvornyi commented 7 years ago

Hello everyone, first of all I want to apologize for my English I had project on Angular:1.5.7, UIBS:0.13.3, Bootstrap:3.3.6 , but after I had updated UIBS to 1.3.3. I had the bug with ui.bootstrap.modal. My code change default position for modal window. The bug is connected with modal window display, as after update the “callbacks $uibModal.open().rendered” function is fired after the template is displayed on the page. I also got blinking effect, which I did not have with version 0.13.3. before: image

Possible solutions

I investigated the code of both versions and I think I can offer possible solution. If I comment this row $q.when(animationPromise).then(function() { , it can resolve this problem

cc @wesleycho, @christopherthielen

icfantv commented 7 years ago

Closing per comments in rejected PR.

Your upgrade is quite a big jump. Did you work through the breaking changes sections in ALL the versions from your old one to your new one?