search

angular-ui / bootstrap

PLEASE READ THE PROJECT STATUS BELOW. Native AngularJS (Angular) directives for Bootstrap. Smaller footprint (20kB gzipped), no 3rd party JS dependencies (jQuery, bootstrap JS) required. Please read the README.md file before submitting an issue!
http://angular-ui.github.io/bootstrap/
MIT License
14.3k stars 6.74k forks source link

feat($uibModal): bind resolve properties to controller when opening modal as component #6569

Closed austinleroy closed 2 years ago

austinleroy commented 7 years ago

Bind resolve properties to controller of component opened with $uibModal. This mimics current uiRouter usage of resolve so any component can receive input data with $uibModal. Previous behavior was to force component to expose a resolve binding.

Closes #6540

eseliger commented 7 years ago

Would love to see that merged, so we can reuse our modal components anywhere else in applications

AnimaLupi commented 7 years ago

Indeed, it's a much needed merge to ensure reusability...

austinleroy commented 7 years ago

I'd like to note that this PR is usable only for binding data to the component. Binding of callback functions is still not available. If that were ever to be supported, I believe it would not be a part of resolve.

That being said, this would still improve the reusability of any component opened with $uibModal.

bitflower commented 7 years ago

In which version will this be included? I could patch but it's a big project with many devs on board...

bitflower commented 6 years ago

@austinleroy Do you understand the problem with Travis? Would love to see this merged ;-)

austinleroy commented 6 years ago

@bitflower It looks like the Travis build failed due to a timeout when running the karma task. The build should work correctly if another one is kicked off - I can't do it myself because I don't have write access to this repo

austinleroy commented 6 years ago

I read that if I close the PR and reopen it, a new Travis build will kick off...

eseliger commented 6 years ago

For the future: you can also amend your commit and force push it