search

angular-ui / ui-ace

This directive allows you to add ACE editor elements.
http://angular-ui.github.io/ui-ace
MIT License
578 stars 172 forks source link

No license in javascript #65

Open paulberg opened 10 years ago

paulberg commented 10 years ago

The javascript file does not contain any comment as to the source of the code or the license it is under. This makes it difficult for end users to see the license. Could this be added to the source files?

douglasduteil commented 9 years ago

Yes.

richleland commented 9 years ago

Looks like this is already handled by the presence of LICENSE and the license property in bower.json? Or is this adding a banner to the top of the file?

douglasduteil commented 9 years ago

I guess @paulberg wants a banner on the top of each dist files right ? A little bit of grunt concat will do it :+1:

richleland commented 9 years ago

https://github.com/mattstyles/grunt-banner works well too.

douglasduteil commented 9 years ago

Yeah look nice but I would like to tackle the IIFE problem in the same line. So I would be cool to have on the dist task

// The banner
/* bla bla bla */

// The IIFE stuff
(function(window, document, undefined) {'use strict';

  // The src content
  angular.module...

// The final IIFE stuff
})(window, document);
douglasduteil commented 9 years ago

What you think @richleland ?