search

angular-ui / ui-ace

This directive allows you to add ACE editor elements.
http://angular-ui.github.io/ui-ace
MIT License
578 stars 172 forks source link

feat(config): always call the global `onLoad` handler #78

Closed marshall007 closed 9 years ago

marshall007 commented 9 years ago

In my project, I wanted to setup Ace in the uiAceConfig.ace.onLoad handler because I was setting a lot of "advanced" options anyway. I then needed to configure hotkeys on individual Ace instances, which wiped out the global onLoad handler.

With this PR, the global onLoad handler is always called first followed by the instance onLoad if specified.

marshall007 commented 9 years ago

Note: build is failing for the reasons outlined in #77, it's not a result of this PR.

douglasduteil commented 9 years ago

Hi @marshall007 Can you rebase your PR plz ?

marshall007 commented 9 years ago

@douglasduteil yep, done!

douglasduteil commented 9 years ago

Thanks ! Merged with https://github.com/angular-ui/ui-ace/commit/c83086ac7be7ff08dd632ab6705c43ba39ca6867