search

angular-ui / ui-ace

This directive allows you to add ACE editor elements.
http://angular-ui.github.io/ui-ace
MIT License
578 stars 172 forks source link

$applyAsync() is only in Angular v1.3 and above. #91

Open gamebox opened 9 years ago

gamebox commented 9 years ago

I assume your intention was to continue supporting those of us lingering on the 1.1.x and 1.2.x branches, but unfortunately moving from $apply() to $applyAsync() has failed in that endeavor. I haven't read the conversation for why that move needed to be made, but the newer function is undefined on $scope in earlier branches and this causes erratic, breaking behavior.

jmartin4563 commented 9 years ago

We actually just got bit by this as well, thankfully only on a staging instance of our code, but now blocking our push to production

jmartin4563 commented 9 years ago

Just as a note for other people suffering from this, downgrading to 0.1.1 fixes the issue. This is the offending commit: https://github.com/angular-ui/ui-ace/commit/0732ea769c99a2225e97d1d1dd27f46a19593950

douglasduteil commented 9 years ago

Hum... Will it help if I make another angular-ui/ui-ace@1.1.x release with a fixed version dep to angular@1.2.x ?

gamebox commented 9 years ago

@douglasduteil Probably. Just stay away form v1.3 stuff for now, or move that to a major release branch.

@jmartin4563 We did the same thing, was surprised to see a breaking change in a minor release, just changed the ~ in our bower dependencies