search

angular-ui / ui-calendar

A complete AngularJS directive for the Arshaw FullCalendar.
http://angular-ui.github.io/ui-calendar/
MIT License
1.49k stars 729 forks source link

TODO for angular conversion #138

Open zackarychapple opened 10 years ago

zackarychapple commented 10 years ago
Urigo commented 10 years ago

What do you think about my pull request of ui-bootstrap's date picker? Look at the example: https://github.com/angular-ui/bootstrap/pull/2619

It might be a good start no?

mattcasey commented 10 years ago

For the record, if you update ui-calendar to support fullcalendar.js 2.1.0, you can cross out jquery-ui dependency. It would also be a good step before trying to remove CSS dependency since they removed tables for layout: https://github.com/arshaw/fullcalendar/releases

My two cents, though: I think this 'issue' is not just an issue, but a proposal for a whole other project. ui-calendar is ~200 lines, fullcalendar is ~7000, and it doesn't seem like you can easily remove any one of fullcalendar's dependencies without first removing fullcalendar. Also, after you remove fullcalendar, I'm sure the calendars will grow to provide different features. I don't mean to debate the value of an Angular-only calendar, but maybe some people just want a wrapper around fullcalendar, and they'll be stuck with a legacy version of ui-calendar that won't be maintained. I'm curious if this perspective has been considered?

Urigo commented 10 years ago

@mattcasey I agree with you, and once fullcalendar 2.1.0 will be out of beta i'm going to merge it as well, but I think those are to parallel things. And don't forget - you are comparing JQuery lines of code to Angular lines of code and ui-bootstrap's datepicker has a lot of them as well :)

joshkurz commented 10 years ago

I agree that when we do create a new angular only calendar, it should be in its own repo. On Aug 21, 2014 5:16 PM, "Matt Casey" notifications@github.com wrote:

For the record, if you update ui-calendar to support fullcalendar.js 2.1.0, you can cross out jquery-ui dependency. It would also be a good step before trying to remove CSS dependency since they removed tables for layout: https://github.com/arshaw/fullcalendar/releases

My two cents, though: I think this 'issue' is not just an issue, but a proposal for a whole other project. ui-calendar is ~200 lines, fullcalendar is ~7000, and it doesn't seem like you can easily remove any one of fullcalendar's dependencies without first removing fullcalendar. Also, after you remove fullcalendar, I'm sure the calendars will grow to provide different features. I don't mean to debate the value of an Angular-only calendar, but maybe some people just want a wrapper around fullcalendar, and they'll be stuck with a legacy version of ui-calendar that won't be maintained.

— Reply to this email directly or view it on GitHub https://github.com/angular-ui/ui-calendar/issues/138#issuecomment-52985928 .

mattcasey commented 10 years ago

That's great to hear, guys. I think we're all on the same page. It just was not very obvious :)

I also think the angular-calendar could have a much nicer API, another reason to have a different project.

Urigo commented 10 years ago

Cool. so what do you think about my pull request? ;)

mattcasey commented 10 years ago

It's funny, datepicker was one of the reasons I am using angular-strap alongside ui-bootstrap. It was back in April that I had to choose, I can't remember the exact feature that was missing at the time, though. Looking at it now, seems like I could use either.

I recently issued a PR to angular-strap to add a class for today's date, and was wondering if a more generic solution like yours would be better! So I like the update and can see it as a benefit over other datepickers, though not sure why it would not make me more likely to use fullcalendar.

zackarychapple commented 10 years ago

I'll just drop this here. https://github.com/angular-ui/ui-calendar2

Urigo commented 10 years ago

@mattcasey In one of my apps, I had to create a calendar similar to AirBnB's calendar. it means that I need to have general statuses by day on the calendar and if I click on a specific date I can edit it's properties (like availability). I think this is a very common use case and a lot of people use calendar for that reason. So that pull request offers a very general solution for that need. Maybe you can specify your use cases and I can see if and how this pull request can solve those as well.