angular-ui / ui-calendar

A complete AngularJS directive for the Arshaw FullCalendar.
http://angular-ui.github.io/ui-calendar/
MIT License
1.49k stars 728 forks source link

Added Support for angular 1.4.1 #287

Closed kamthamc closed 9 years ago

kamthamc commented 9 years ago
ballerabdude commented 9 years ago

There has been some changes merged in before this one which may have created a conflict. @kamthamc try to pull the latest.

kamthamc commented 9 years ago

@ballerabdude Reverted Formatting and fixed merge conflicts

galuszkak commented 9 years ago

Now it looks far more better to read!! Thanks @kamthamc :)

galuszkak commented 9 years ago

+1 for me. I maybe don't understand part with changing internal methods like destroy, or init. But if test works then I'm ok with that :+1: .

kamthamc commented 9 years ago

Angular has scope.$destroy method. So, just renamed to avoid confusion. Used same name convention for init.

Thanks and Regards Kamatham Chaitanya Kumar

On Jul 9, 2015, at 12:10 AM, Kamil Gałuszka notifications@github.com wrote:

+1 for me. I maybe don't understand part with changing internal methods like destroy, or init. But if test works then I'm ok with that .

— Reply to this email directly or view it on GitHub.

ballerabdude commented 9 years ago

if you try running grunt we get an angular not defined error and when I add angular to the global list it still fails. Can you take a look please?

kamthamc commented 9 years ago

Did you do do a bower install. The tests and demo are working which is isn't possible if angular is not defined

Thanks and Regards Kamatham Chaitanya Kumar

On Jul 9, 2015, at 5:46 AM, Abdul Hagi notifications@github.com wrote:

if you try running grunt we get an angular not defined error and when I add angular to the global list it still fails. Can you take a look please?

— Reply to this email directly or view it on GitHub.