angular-ui / ui-calendar

A complete AngularJS directive for the Arshaw FullCalendar.
http://angular-ui.github.io/ui-calendar/
MIT License
1.49k stars 728 forks source link

Memory leak on 1.0.1 fixed on master, please T&R 1.0.2 with fix? #387

Open martin-langhoff opened 8 years ago

martin-langhoff commented 8 years ago

v1.0.1 has a nasty memory leak, which is fixed on master. Unfortunately...

I can confirm that v1.0.1 leaks calendars because it does not handle scope destroy, I can confirm that current master is fixed, and the code execution goes right through the scope.$on('destroy') handler installed in the patch above.

Please kindly tag and release a 1.0.2 with a fix?

martin-langhoff commented 8 years ago

It turns out current master has other unaddressed bugs. I have backported and tidied up the memleak fix at https://github.com/martin-langhoff/ui-calendar/releases/tag/1.0.2ml .

You can use this in bower with git://github.com/martin-langhoff/ui-calendar.git#1.0.2ml

martin-langhoff commented 8 years ago

If anyone considers opening a 1.0.x stable branch for this project, I would be happy to submit the fix as a PR, see https://github.com/martin-langhoff/ui-calendar/tree/1.0.x

martin-langhoff commented 8 years ago

The branch mentioned above passes the builtin tests.

martin-langhoff commented 8 years ago

This is addressed by 2702f1c on maint-1.0 branch.