moment is undefined when using requirejs

[Ephapox]

I'm using ui calendar with requirejs and I ran into an issue with loading moment.

require.config({
  paths: {
    "angular": "angular",
    "ui-calendar": "calendar",
    "fullcalendar": "fullcalendar",
    "moment": "moment"
  },
  shim: {
    'angular': {
      exports: 'angular'
    },
    'ui-calendar': {
      'deps': ['angular', 'fullcalendar', 'moment']
    },
    'moment': {
      exports: 'moment'
    },
    'fullcalendar': {
      'deps': ['moment']
    }
  }
});

require(['angular', 'ui-calendar'], function(angular){
    angular.module('app', []).controller('myCtrl', [function(){
      this.eventSources = [// Event Objects]
    }])
})

The calendar renders and has my events loaded on the correct dates but I get a moment is undefined error coming from calendar.js.

It is coming from lines 45-56

var start = moment.isMoment(e.start) ? e.start.unix() : (e.start ? moment(e.start).unix() : '');
var end =   moment.isMoment(e.end)   ? e.end.unix()   : (e.end   ? moment(e.end).unix()   : '');

It seems like there isn't support for loading dependencies with requirejs.

fullcalendar implements support for requirejs with this conditional

if(typeof define === 'function' && define.amd) {
  define(['moment'], factory);
} else {
  factory();
}

function factory(moment) {
  return // ui.calendar module
}

I just wanted to make sure this isn't something that has been brought up before or goes against what the creator wanted before I submit a PR.

[martin-langhoff]

Hi! thanks for raising this.

I'd be open to a PR that sorts this out. While I am not a user of requirejs, it seems to be a good and popular solution.

Can I ask you for a back port to the maint-1.0 branch as well?

[R-iskey]

Hi , please look at my example with require.js 'ui.calendar' : { deps: ['angular', 'fullcalendar','jquery','moment'] },

I don't have 'fullcalendar': { 'deps': ['moment'] }

and second, please insert ui-calendar in your angular module DI.

[amelgoza]

Hi, Is there a solution to this problem??...I am currently having this same issue?

[mikkelking]

+1 I have tried every way to solve this, even using angular-moment, moment on it's own, moment-timezone, but it stubbornly fails. Any help or ideas would be appreciated - this is a show stopper for me.

[poojagayake]

Please verify that moment.ja is loaded in browser or not.

[amelgoza]

@poojagayake That was my issue moment.js was not loading. Once I got moment.js loading correctly everything worked fine.

[AlienSKP]

Has anyone found a workaround on that issue ? I'm having the same problem. I'm using angularJS v1.6 with requireJS too. Moment is loaded in browser, but it stills throws an error "moment is undefined"

[poojagayake]

Is there any JS which needs moment.js to be load first and you missed the dependency.

[AlienSKP]

Tanks for your answer. I solved the problem by Loading moment and firing moment().format() right before line 49

[vaishali-ghayal]

Moment is loaded in browser,still I am facing same problem. Any workaround?

[liuhuiiris126]

I solved the problem ,but I think this way is not good. 1.if you declared the dependency, you can try this way

'ui.calendar':          ['jquery','fullcalendar', 'angular'],

define([
  'moment',
  'jquery',
  'angular',
  'ui.calendar',
  'fullcalendar'
],
function (moment, $, angular,  uiCalendarConfig) {
  'use strict';
  angular.module('app', []).controller('myCtrl', [function(){
  }])

2. if you didn't declared the dependency, you can try this way

   define([
   'moment',
   'jquery',
   'angular',
   'ui.calendar',
   'fullcalendar'
   ],
   function (moment, $, angular,  uiCalendarConfig) {
   'use strict';
   angular.module('app', []).controller('myCtrl', [function(){
     window.moment = moment;
     ....
   }])
   });