angular-ui / ui-grid

UI Grid: an Angular Data Grid
http://ui-grid.info
MIT License
5.39k stars 2.47k forks source link

Custom sortingAlgorithm with large data set and virtualization #4399

Open itjustwerks opened 9 years ago

itjustwerks commented 9 years ago

I have a date column that is stored as a string in the JSON. In order to sort this, I'm using a custom sortingAlgorithm on the column with the following definition:

{
    displayName: 'Date Approved',
    field: 'dateApproved',
    sortingAlgorithm: function (aDate, bDate) {
        var a = moment(aDate);
        var b = moment(bDate);
        if (a < b) {
            return -1;
        }
        else if (a > b) {
             return 1;
        }
        else {
            return 0;
        }
    }
}

This seems to work great for the first chunk of data, but once I get beyond maybe 60 rows or so, it falls apart and the sorting becomes random. For this particular grid, I have about 600 rows, with a filter applied that shows about 100. Is this a known issue?

itjustwerks commented 9 years ago

Can this get the "needs: answer" label as well? The sorting does not seem to work correctly for large data sets. Thanks!