eladh
commented
8 years ago Hi :-)
from the documentation : http://ui-grid.info/docs/#/tutorial/316_dynamic_data_changes
"..... The general AngularJS approach is two way data binding. On every digest cycle every binding is evaluated to see if anything has changed, and updates made as appropriate.
ui-grid explicitly seeks to avoid this. The grid is intended to render large numbers of rows (10K plus), and if all of those rows were evaluated on every digest cycle the performance would be unworkable" Is there any way we can understand why this cell based $watches are created.
we used the following code snippet to see and check the watch count
// taken from http://ng.malsup.com/#!/counting-watchers
(function countAngularWatchers(angular) {
var i, data, scope,
count = 0,
all = [the location of the UI-GRID]
len = all.length,
test = {};
var mostWatchers = 0;
function countScopeWatchers(scope, element) {
test[scope.$id] = true;
var n = scope.$$watchers.length;
count += n;
if (n > mostWatchers) {
console.log('most watchers', n);
console.log(element);
mostWatchers = n;
}
}
// go through each element. Count watchers if it has scope or isolate scope
for (i = 0; i < len; i += 1) {
var el = angular.element(all[i]);
data = el.data();
scope = data.$scope || data.$isolateScope;
if (scope && scope.$$watchers) {
if ( !test[ scope.$id ] ) {
countScopeWatchers(scope, el);
}
}
}
console.log('this page has', count, 'angular watchers');
return count;
}(window.angular));
YonatanKra
Ruud-cb
VioricaMihai
csvan
nitinayir8
NightlyFox
chengwuchao
Hello :-) first i just wanted to say thanks for this great project.
we integrated ui-grid as part of our table-grid , and for some unknown reason the amount of watches generated by the ui-grid is huge for the amount of data we trying to process.
for example : grid - 9 columns table with 20 rows of simple text based cells without any custom cell template
inspecting the $watches we getting amount of 960 watches.
trying to debug this issue we printed each element that has watch on him and most of the times we got this kind of elements :
[ div#1445359168448-19-uiGrid-001Z-cell.ui-grid-cell.ng-scope.ui-grid-coluiGrid-001Z, context: div#1445359168448-19-uiGrid-001Z-cell.ui-grid-cell.ng-scope.ui-grid-coluiGrid-001Z] and each cell element got 2-4 watches.
we used simple data structure with basic columnDefs (field + display name) .
in most of our cases we don't need to watch for chances in specific grid cells.
is there anything we can do to reduce the number of $watches created by ui-grid ?
thanks in advance, elad.