angular-ui / ui-grid

UI Grid: an Angular Data Grid
http://ui-grid.info
MIT License
5.39k stars 2.47k forks source link

ui-grid-selection with ocLazyLoad: row not changing color when selected #6065

Open luqeckr opened 7 years ago

luqeckr commented 7 years ago

hi, today i try 4.0.2 from 3.1.1 i use the ui-grid-selection, with enableRowSelection: true in this new version, the selection is not displayed (the selected row doesn't change it's color)

i try again 3.1.1 and 3.2.9, and it's working fine, but starting v4.0.0 the selected row color not changing the $scope.gridApi.selection.getSelectedRows()[0] is working, i can get the selected row data in any version

mportuga commented 7 years ago

I cannot reproduce this issue in the tutorial of ui-grid.info or in the following plunker http://plnkr.co/edit/?p=preview http://ui-grid.info/docs/#/tutorial/210_selection

Can you make a plunker with your issue so that I can see it?

luqeckr commented 7 years ago

i've try using plunker http://plnkr.co/edit/LQvY6SW047dZNlsUSB1Q?p=preview and it's working fine.. it's not complete rewrite of my code though

but i got the point in my real code, i lazyload the uigrid using ocLazyLoad, then the selection color not working (not displayed) when using 4.0.2, but working fine using 3.2.9

using 4.0.2, i removed the lazyload, and load the ui.grid the normal way, then it's working

so, my solution is to use lazyload, use 3.2.9 and when not using lazyload, 4.0.2 is fine.. but i hope i can still lazyload with 4.0.2

rodenj1 commented 7 years ago

I am actually running into the same issue within one of my apps where the row does not change color with 4.0.x but does with 3.2.9. I am using OClazyload as well. I am going to see if I can work up an example to demonstrate.

sjoerd222888 commented 7 years ago

I have the same issue, selection does not work if ui-gird is lazy-loaded using ocLazyLoad. @rodenj1 Did you already open an issue at ocLazyLoad? I suspect something is going wrong at this side. (However if I look at the library I see a lot of open issues, seems this library is not really maintained.)

rodenj1 commented 7 years ago

I did not open a case with ocLazyLoad, and probably should of… :( At this point I have started loading ui-grid not using ocLazyLoad as my app was pretty much loading it in 95% of the time anyways. But I do agree, this seeming more like a ocLazyLoad issue then ui-grid

On Jul 26, 2017, at 1:10 AM, Alexander Timmermans notifications@github.com wrote:

I have the same issue, selection does not work if ui-gird is lazy-loaded using ocLazyLoad https://github.com/ocombe/ocLazyLoad. @rodenj1 https://github.com/rodenj1 Did you already open an issue at ocLazyLoad https://github.com/ocombe/ocLazyLoad? I suspect something is going wrong at this side. (However if I look at the library I see a lot of open issues, seems this library is not really maintained.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/angular-ui/ui-grid/issues/6065#issuecomment-317981312, or mute the thread https://github.com/notifications/unsubscribe-auth/AH7hevB5LtXiVbgQHplFhpZfn4TvcS4Gks5sRvRngaJpZM4MWWyM.

eBitzu commented 6 years ago

Hello,

I've investigated a little the problem since I have the same issue. ocLazyLoad loads your modules but they don't compile them right, I had to change the priority of the ui.grid.expandable module so it will work.

An other solution will be to add the modules direct into the main app, since you are getting the entire file anyway, just add them to the "app" modules dependencies.

(function () { angular.module('app', ['ui.grid', 'ui.grid.expandable', 'ui.grid.selection', 'ui.grid.pinning', 'ui.grid.autoResize'])

Hope it helps