search

angular-ui / ui-grid

UI Grid: an Angular Data Grid
http://ui-grid.info
MIT License
5.39k stars 2.47k forks source link

Grid Column Resizer leaves margin at the right end of last header column #6824

Open elliotpj opened 6 years ago

elliotpj commented 6 years ago

Enabling ui-grid-resize-columns leaves a margin at the right side of last header column on v4.6.2, which wasnt the issue in v4.0.0

Margin gets hidden below the ui-grid-menu-button, but in my case height of the header gets changed due to additional filters

imageedit_1_5538927245

for now i have overwritten the class present in ui-grid.css file to minimise the margin width 

.ui-grid-header-cell-last-col + .ui-grid-column-resizer.right {
    margin-right: 0px !important;
 }

imageedit_3_3171336784

is there any reason for increasing margin right value at the last header column ,if so is there any other way to fix this like setting up ui-grid-menu-button height dynamically according to the the ui-grid-header height

mportuga commented 6 years ago

That margin has been a cause of pain for myself for a while now. It is added for scrollbars, but unfortunately it does not work quite like it should. I am going to try spending some time trying to fix this, but unfortunately, I have no recommendations right now, other than messing with the CSS as you've already been doing. If you have an idea and can open a PR, that will be appreciated.