angular-ui / ui-grid

UI Grid: an Angular Data Grid
http://ui-grid.info
MIT License
5.39k stars 2.47k forks source link

afterCellEdit event fired with horizontal scroll not allowing to edit cell via tabbing #7084

Closed piyush21upadhyay closed 4 years ago

piyush21upadhyay commented 4 years ago

Hi,

We are using the editable grid where user can navigate through cells via tabbing and edit the cell. Things work as expected till we have horizontal scroll either not present on the screen OR scroller has not been moved forward from its initial zero position.

Ex: say while tabbing till cell 6 horizontal scroller remains stable, so till that cell user can tab, focus and edit the cell. The moment we move to cell 7 and scroller moves forward, user can tab to cell 7, focus works on cell 7 too but cell becomes non editable, reason being the call to afterCellEdit event in deregOnGridScroll section (beginEditAfterScroll function) present in ui-grid-edit.js. User can surely edit the cell by clicking on it OR scrolling the horizontal bar, but it goes against the tabbing/focusing/editing feature of ui-grid and defeats the purpose. Could you guys help me here, so that user can keep on editing the cell from 1st column till the last one by tabbing through cells with scroller moving forward?

Below is the Plunkr where the issue is getting replicated with ui-grid: 4.6.2 version where user can navigate and edit the first three cells on tab as they are only visible at initial point of scroll. On further tabbing, user can not edit the cells- PlunkrLink

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been automatically closed because it has not had recent activity. If you believe that this is still an issue in the latest version, feel free to re-open it. Thank you for your contributions.