We need to upgrade Angular to 1.8.0

angular-ui / ui-grid

UI Grid: an Angular Data Grid

http://ui-grid.info

MIT License

5.39k stars 2.47k forks source link

We need to upgrade Angular to 1.8.0 #7091

Closed caok2709 closed 4 years ago

caok2709 commented 4 years ago

Noticed that our angular version is still 1.7.9 Latest angular 1.8.0 published recently.

carlas0fia commented 4 years ago

I'm also upgrading to 1.8.0, could it be a problem?

natpicone commented 4 years ago

Looks like master supports angularjs 1.8.0 but build has failed. @mportuga can you please check this out? Thx

natpicone commented 4 years ago

After more checks here is the status:

version 4.8.3 supports angularjs 1.7.9
master has support for angularjs 1.8.0 but build is broken (maybe it just needs to be re-tried) and it has not been tagged as new release

I really need that somebody take a look at this otherwise I won't be able to close the security issue of angularjs 1.7.9.

Github security panel doesn't report any issue because the master dependencies are correct. It doesn't know that the master version has not been released yet.

@caok2709 / @mportuga can you help on this please?

Thanks

cristianp6 commented 4 years ago

Hi all! I need to upgrade to angularjs 1.8.0 too, can the broken build be fixed and release it? Many thanks!

@mportuga

cristianpascottini commented 4 years ago

Hi guys, v4.8.5 published on npm registry still depends on AngularJS 1.7.9.

mportuga commented 4 years ago

Whoops, I missed one package.json file, thanks for the catch

cristianpascottini commented 4 years ago

Great, now it installs AngularJS v.1.8.0! Thanks! 👍🏻