angular-ui / ui-grid

UI Grid: an Angular Data Grid
http://ui-grid.info
MIT License
5.39k stars 2.47k forks source link

chore: 🤖 add angularJS 1.8 support #7117

Closed mportuga closed 4 years ago

commit-lint[bot] commented 4 years ago

Chore

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
cristianpascottini commented 4 years ago

Many thanks for this, however current npm package still depends on AngularJS 1.7.9:

My package-lock.json after npm install angular-ui-gird:

  "requires": true,
  "lockfileVersion": 1,
  "dependencies": {
    "angular": {
      "version": "1.7.9",
      "resolved": "https://registry.npmjs.org/angular/-/angular-1.7.9.tgz",
    },
    "angular-ui-grid": {
      "version": "4.8.5",
      "resolved": "https://registry.npmjs.org/angular-ui-grid/-/angular-ui-grid-4.8.5.tgz",
      "requires": {
        "angular": ">=1.4.0 1.7.x"
      }
    }
  }
}