angular-ui / ui-grid

UI Grid: an Angular Data Grid
http://ui-grid.info
MIT License
5.39k stars 2.47k forks source link

feat: 🎸 add 'aria-expanded' to expand buttons for accessibility #7138

Closed psalt21 closed 3 years ago

psalt21 commented 3 years ago

Adding the aria-expanded attribute allows the screen reader to let a visually impaired person know if an expandable area is expanded or collapsed.

commit-lint[bot] commented 3 years ago

Features

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
psalt21 commented 3 years ago

That's great, thanks!

On Tue, Jan 26, 2021 at 11:42 PM Ivan Demidov notifications@github.com wrote:

@Scrum approved this pull request.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/angular-ui/ui-grid/pull/7138#pullrequestreview-577023982, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECJAYCHQSPWCDOOXP72G73S36YWDANCNFSM4WUJM35A .

-- Philip Salter Cell: (801)735-3985

Scrum commented 3 years ago

That's great, thanks! … On Tue, Jan 26, 2021 at 11:42 PM Ivan Demidov @.**> wrote: @Scrum* approved this pull request. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7138 (review)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECJAYCHQSPWCDOOXP72G73S36YWDANCNFSM4WUJM35A . -- Philip Salter Cell: (801)735-3985

Unfortunately, I can’t merge va PR until this question is resolved https://github.com/angular-ui/ui-grid/commit/3a4a27f6f1283f9b785287a53c2acc3539de170b#commitcomment-46456362.