search

angular-ui / ui-grid

UI Grid: an Angular Data Grid
http://ui-grid.info
MIT License
5.39k stars 2.47k forks source link

fix: clearSelectedRows should respect enableSelection #7141

Closed blackwolf12333 closed 3 years ago

blackwolf12333 commented 3 years ago

The issue we had was that we have rows that are selected, but also have enableSelection: false. We expected select all to behave similarly when selecting and unselecting all rows in that select all does not touch disabled rows. But unselect all does touch disabled rows.

This fixes the above issue by using the same check that is used during select all behavior in clearSelectedRows.

commit-lint[bot] commented 3 years ago

Bug Fixes

Contributors

blackwolf12333

Commit-Lint commands
You can trigger Commit-Lint actions by commenting on this PR: - `@Commit-Lint merge patch` will merge dependabot PR on "patch" versions (X.X.Y - Y change) - `@Commit-Lint merge minor` will merge dependabot PR on "minor" versions (X.Y.Y - Y change) - `@Commit-Lint merge major` will merge dependabot PR on "major" versions (Y.Y.Y - Y change) - `@Commit-Lint merge disable` will desactivate merge dependabot PR - `@Commit-Lint review` will approve dependabot PR - `@Commit-Lint stop review` will stop approve dependabot PR
Scrum commented 3 years ago

@mportuga

blackwolf12333 commented 3 years ago

@Scrum should I do something about the lint error? I don't see what's wrong with the commit now tbh.

Scrum commented 3 years ago

@Scrum should I do something about the lint error? I don't see what's wrong with the commit now tbh.

unfortunately, I also do not have access there

mportuga commented 3 years ago

That lint error was just an issue with the PR title apparently