search

angular-ui / ui-leaflet-draw

angular directive for ui-leaflet to utilize Leaflet.Draw
http://angular-ui.github.io/ui-leaflet-draw/
16 stars 20 forks source link

Github dependency #23

Open umdstu opened 6 years ago

umdstu commented 6 years ago

Is there still a reason this package needs to be dependent on github:

"leaflet-draw": "git://github.com/michaelguild13/Leaflet.draw.git#master",

instead of Leaflet.Draw since it's in NPM ?

nmccready commented 6 years ago

Probably not, feel free to submit a PR.

umdstu commented 6 years ago

Seems simple enough, but since this is currently pointing to something several years old (and several hundred commits behind /Leaflet/Leaflet.draw, what are the chances of this working with the 'current' version of Leaflet.draw?

nmccready commented 6 years ago

I don't really have any idea. I don't really have time to commit to that right now. I would assume it would not.

Also the repo git://github.com/michaelguild13/Leaflet.draw.git#master is a fork by @michaelguild13 which did not seem to be published to NPM . The reason for pointing to that fork; was at the time he was the only one that supported touch screens correctly. I would hope that this has been resolved by now .